fix(net): fix the unclear reason codes returned in disconnection messages #6394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxo1shine
approved these changes
Jul 9, 2025
jwrct
changed the title
Sunny6889
approved these changes
Jul 10, 2025
bladehan1
approved these changes
Jul 11, 2025
kuny0707
approved these changes
Jul 14, 2025
halibobo1205
approved these changes
Jul 14, 2025
barbatos2011
approved these changes
Jul 15, 2025
| @@ -126,13 +126,27 @@ public void testInvalidHelloMessage() { | |||
| //block hash is empty | |||
| try { | |||
| BlockCapsule.BlockId hid = ChainBaseManager.getChainBaseManager().getHeadBlockId(); | |||
| Protocol.HelloMessage.BlockId hBlockId = Protocol.HelloMessage.BlockId.newBuilder() | |||
| .setHash(ByteString.copyFrom(new byte[0])) | |||
| Protocol.HelloMessage.BlockId okBlockId = Protocol.HelloMessage.BlockId.newBuilder() | |||
There was a problem hiding this comment.
what about using "validBLockId" instead of "okBlockId"?
There was a problem hiding this comment.
Test case adjustment only.
lvs0075
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #5989
Why are these changes required?
This PR has been tested by:
Follow up
Extra details